fix(replay): Do not use recycled screenshots #4790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-java into markushi/canvas-approach
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
sentry-android-replay/src/main/java/io/sentry/android/replay/util/ReplayExecutorService.kt
Show resolved
Hide resolved
sentry-android-replay/src/main/java/io/sentry/android/replay/util/ReplayExecutorService.kt
Show resolved
Hide resolved
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b3d8889 | 420.46 ms | 453.71 ms | 33.26 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| 9fbb112 | 361.43 ms | 427.57 ms | 66.14 ms |
| cf708bd | 408.35 ms | 458.98 ms | 50.63 ms |
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| cf708bd | 434.73 ms | 502.96 ms | 68.22 ms |
| bdbe1f4 | 380.66 ms | 464.44 ms | 83.78 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| f634d01 | 375.06 ms | 420.04 ms | 44.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| bdbe1f4 | 1.58 MiB | 2.11 MiB | 538.88 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
markushi
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
recorder.close()is called from a different thread after we captured the screenshot, but before masking is applied) which resulted in native crashes when initing aCanvasbacked by it. This PR checks for bitmap.isRecycled and recorder being closed before doing anything with the screenshot.ReplayExecutorServicewhich allows us to abstract away our "safe" way of submitting runnables, but also allows us to override this behaviour in tests in case we want a test to actual fail because of the exception thrown inside runnable.💡 Motivation and Context
Closes getsentry/sentry-react-native#5159
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps